Closed Karolk99 closed 5 months ago
Merging #369 (66a411b) into master (edeaac4) will increase coverage by 0.78%. The diff coverage is 77.19%.
0.78%
77.19%
Codecov Report
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #369 +/- ## ========================================== + Coverage 52.61% 53.39% +0.78% ========================================== Files 59 61 +2 Lines 2545 2592 +47 ========================================== + Hits 1339 1384 +45 - Misses 1206 1208 +2 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [...on\_test/test/support/crashing\_recording\_storage.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-aW50ZWdyYXRpb25fdGVzdC90ZXN0L3N1cHBvcnQvY3Jhc2hpbmdfcmVjb3JkaW5nX3N0b3JhZ2UuZXg=) | `100.00% <100.00%> (ø)` | | | [recording/lib/storage/file.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL2ZpbGUuZXg=) | `100.00% <ø> (ø)` | | | [recording/lib/storage/s3.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL3MzLmV4) | `93.33% <93.33%> (ø)` | | | [recording/lib/storage/s3/sink.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL3MzL3NpbmsuZXg=) | `90.62% <90.62%> (ø)` | | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/369?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute