search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

PossiblyInvalidTrackNames #371

Closed noozo closed 1 month ago

noozo commented 5 months ago

Filename with colon might be invalid on some systems

noozo commented 5 months ago

In all honesty, this might need fixing at the track_id name level or have a file name generation function that does not generate names with ":", because what i did here doesn't actually fix anything :)

mickel8 commented 5 months ago

Hi @noozo, thanks for spotting this! Actually, why doesn't this fix anything? We generate track id as endpoint_id:track_id where both endpoint_id and track_id are some uuids as far as I remember :thinking: