search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Refactor storage API #375

Closed Karolk99 closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

Merging #375 (9798f2e) into master (a222207) will decrease coverage by 0.13%. Report is 2 commits behind head on master. The diff coverage is 46.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 53.31% 53.18% -0.13% ========================================== Files 61 59 -2 Lines 2592 2587 -5 ========================================== - Hits 1382 1376 -6 - Misses 1210 1211 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [recording/lib/storage/file.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL2ZpbGUuZXg=) | `100.00% <100.00%> (ø)` | | | [recording/lib/storage/s3.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL3MzLmV4) | `94.11% <100.00%> (+0.78%)` | :arrow_up: | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [a222207...9798f2e](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/375?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).