search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Extend recording report created by RecordingEndpoint #376

Closed Rados13 closed 5 months ago

Rados13 commented 5 months ago

In the recording report, we need the start timestamp and end timestamp of the track.

codecov[bot] commented 5 months ago

Codecov Report

Merging #376 (5c26f91) into master (e1d5c4d) will decrease coverage by 0.23%. The diff coverage is 38.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ========================================== - Coverage 53.27% 53.04% -0.23% ========================================== Files 61 62 +1 Lines 2596 2624 +28 ========================================== + Hits 1383 1392 +9 - Misses 1213 1232 +19 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [recording/lib/reporter.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZXBvcnRlci5leA==) | `100.00% <100.00%> (ø)` | | | [recording/test/support/mock\_track.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL3Rlc3Qvc3VwcG9ydC9tb2NrX3RyYWNrLmV4) | `100.00% <100.00%> (ø)` | | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | | [recording/lib/edge\_timestamp\_saver.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9lZGdlX3RpbWVzdGFtcF9zYXZlci5leA==) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [e1d5c4d...5c26f91](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/376?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).