fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Add metrics to recording endpoint and cleanup on s3 upload error #378

Closed Karolk99 closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

Merging #378 (9cc8bfc) into master (17bb6fc) will increase coverage by 0.25%. The diff coverage is 71.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #378 +/- ## ========================================== + Coverage 53.04% 53.30% +0.25% ========================================== Files 62 62 Lines 2624 2634 +10 ========================================== + Hits 1392 1404 +12 + Misses 1232 1230 -2 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [recording/lib/storage/s3/sink.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL3MzL3NpbmsuZXg=) | `93.18% <100.00%> (+2.55%)` | :arrow_up: | | [recording/lib/edge\_timestamp\_saver.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9lZGdlX3RpbWVzdGFtcF9zYXZlci5leA==) | `0.00% <0.00%> (ø)` | | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [17bb6fc...9cc8bfc](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/378?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).