search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Try fix s3 objects if file storage is present #380

Closed Karolk99 closed 4 months ago

codecov[bot] commented 5 months ago

Codecov Report

Merging #380 (395f00d) into master (2a0952a) will increase coverage by 0.31%. The diff coverage is 66.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #380 +/- ## ========================================== + Coverage 53.28% 53.59% +0.31% ========================================== Files 62 62 Lines 2635 2685 +50 ========================================== + Hits 1404 1439 +35 - Misses 1231 1246 +15 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [recording/lib/storage/file.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?src=pr&el=tree&filepath=recording%2Flib%2Fstorage%2Ffile.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL2ZpbGUuZXg=) | `90.00% <75.00%> (-10.00%)` | :arrow_down: | | [recording/lib/storage/s3.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?src=pr&el=tree&filepath=recording%2Flib%2Fstorage%2Fs3.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL3MzLmV4) | `94.44% <92.30%> (+0.32%)` | :arrow_up: | | [recording/lib/guard.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?src=pr&el=tree&filepath=recording%2Flib%2Fguard.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9ndWFyZC5leA==) | `0.00% <0.00%> (ø)` | | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?src=pr&el=tree&filepath=recording%2Flib%2Frecording_endpoint.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [2a0952a...395f00d](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/380?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).