search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

RTC-510 Manual subscribe mode #383

Closed Rados13 closed 4 months ago

codecov[bot] commented 5 months ago

Codecov Report

Merging #383 (021a14b) into master (3b62be9) will increase coverage by 0.77%. The diff coverage is 58.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #383 +/- ## ========================================== + Coverage 53.94% 54.72% +0.77% ========================================== Files 61 64 +3 Lines 2671 2719 +48 ========================================== + Hits 1441 1488 +47 - Misses 1230 1231 +1 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [...ne/lib/membrane\_rtc\_engine/subscriber/automatic.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=engine%2Flib%2Fmembrane_rtc_engine%2Fsubscriber%2Fautomatic.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL3N1YnNjcmliZXIvYXV0b21hdGljLmV4) | `100.00% <100.00%> (ø)` | | | [...ngine/lib/membrane\_rtc\_engine/subscriber/manual.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=engine%2Flib%2Fmembrane_rtc_engine%2Fsubscriber%2Fmanual.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL3N1YnNjcmliZXIvbWFudWFsLmV4) | `100.00% <100.00%> (ø)` | | | [hls/lib/hls\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=hls%2Flib%2Fhls_endpoint.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-aGxzL2xpYi9obHNfZW5kcG9pbnQuZXg=) | `51.88% <ø> (+0.97%)` | :arrow_up: | | [recording/lib/storage/s3.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=recording%2Flib%2Fstorage%2Fs3.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9zdG9yYWdlL3MzLmV4) | `94.44% <100.00%> (ø)` | | | [engine/lib/membrane\_rtc\_engine/subscriber.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=engine%2Flib%2Fmembrane_rtc_engine%2Fsubscriber.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-ZW5naW5lL2xpYi9tZW1icmFuZV9ydGNfZW5naW5lL3N1YnNjcmliZXIuZXg=) | `61.90% <61.90%> (ø)` | | | [sip/lib/sip\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=sip%2Flib%2Fsip_endpoint.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-c2lwL2xpYi9zaXBfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | | [recording/lib/recording\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?src=pr&el=tree&filepath=recording%2Flib%2Frecording_endpoint.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZWNvcmRpbmdfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [3b62be9...021a14b](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/383?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).