search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Merge membrane_webrtc_plugin #384

Closed mickel8 closed 4 months ago

mickel8 commented 4 months ago

membrane_webrtc_plugin is not intended to be used outside membrane_rtc_engine as it is too tightly coupled to the webrtc endpoint.

Because of that, and because Membrane Team created a new membrane_webrtc_plugin that uses Elixir WebRTC under the hood and has a brand new API, we want to merge the old membrane_webrtc_plugin and release its name for the new Membrane's package.

New Membrane's plugin: https://github.com/membraneframework-labs/membrane_webrtc_plugin Old Jellyfish plugin: https://github.com/jellyfish-dev/membrane_webrtc_plugin

codecov[bot] commented 4 months ago

Codecov Report

Merging #384 (1677afb) into master (5500016) will decrease coverage by 0.31%. The diff coverage is 52.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #384 +/- ## ========================================== - Coverage 54.66% 54.36% -0.31% ========================================== Files 64 75 +11 Lines 2720 3254 +534 ========================================== + Hits 1487 1769 +282 - Misses 1233 1485 +252 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [webrtc/lib/webrtc\_endpoint.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fwebrtc_endpoint.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi93ZWJydGNfZW5kcG9pbnQuZXg=) | `0.00% <ø> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/mid.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Fmid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL21pZC5leA==) | `83.33% <83.33%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/rid.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Frid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3JpZC5leA==) | `83.33% <83.33%> (ø)` | | | [webrtc/lib/endpoint\_bin/metrics.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fmetrics.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vbWV0cmljcy5leA==) | `0.00% <0.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uLmV4) | `60.00% <60.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/repaired\_rid.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Frepaired_rid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3JlcGFpcmVkX3JpZC5leA==) | `16.66% <16.66%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/vad.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Fvad.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3ZhZC5leA==) | `0.00% <0.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/twcc.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Ftwcc.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3R3Y2MuZXg=) | `0.00% <0.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/utils.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Futils.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vdXRpbHMuZXg=) | `0.00% <0.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/track.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Ftrack.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vdHJhY2suZXg=) | `77.10% <77.10%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [5500016...1677afb](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/384?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).