search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Recording Endpoint: add origin to report #387

Closed Karolk99 closed 4 months ago

Karolk99 commented 4 months ago

The origin field in report is necessary to pair audio and video tracks

codecov[bot] commented 4 months ago

Codecov Report

Merging #387 (14ce5ab) into master (78bfa05) will increase coverage by 0.07%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #387 +/- ## ========================================== + Coverage 54.04% 54.11% +0.07% ========================================== Files 74 75 +1 Lines 3249 3254 +5 ========================================== + Hits 1756 1761 +5 Misses 1493 1493 ``` | [Files](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/387?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) | Coverage Δ | | |---|---|---| | [recording/lib/reporter.ex](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/387?src=pr&el=tree&filepath=recording%2Flib%2Freporter.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev#diff-cmVjb3JkaW5nL2xpYi9yZXBvcnRlci5leA==) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/387/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/387?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/387?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Last update [78bfa05...14ce5ab](https://app.codecov.io/gh/jellyfish-dev/membrane_rtc_engine/pull/387?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jellyfish-dev).