Closed Karolk99 closed 3 months ago
Attention: Patch coverage is 72.13115% with 17 lines in your changes are missing coverage. Please review.
72.13115%
17 lines
Project coverage is 55.22%. Comparing base (2708790) to head (84121c5).
2708790
84121c5
Codecov Report
Attention: Patch coverage is
72.13115%
with17 lines
in your changes are missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #393 +/- ## ========================================== + Coverage 54.95% 55.22% +0.27% ========================================== Files 75 75 Lines 3259 3299 +40 ========================================== + Hits 1791 1822 +31 - Misses 1468 1477 +9 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [recording/lib/edge\_timestamp\_saver.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=recording%2Flib%2Fedge_timestamp_saver.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-cmVjb3JkaW5nL2xpYi9lZGdlX3RpbWVzdGFtcF9zYXZlci5leA==) | `100.00% <100.00%> (ø)` | | | [recording/test/support/mock\_track.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=recording%2Ftest%2Fsupport%2Fmock_track.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-cmVjb3JkaW5nL3Rlc3Qvc3VwcG9ydC9tb2NrX3RyYWNrLmV4) | `100.00% <100.00%> (ø)` | | | [rtsp/lib/rtsp/connection\_manager.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=rtsp%2Flib%2Frtsp%2Fconnection_manager.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-cnRzcC9saWIvcnRzcC9jb25uZWN0aW9uX21hbmFnZXIuZXg=) | `82.65% <100.00%> (+2.04%)` | :arrow_up: | | [webrtc/lib/endpoint\_bin/endpoint\_bin.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fendpoint_bin.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZW5kcG9pbnRfYmluLmV4) | `37.19% <100.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/mid.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Fmid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL21pZC5leA==) | `83.33% <100.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/rid.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Frid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3JpZC5leA==) | `83.33% <100.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/track.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Ftrack.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vdHJhY2suZXg=) | `77.10% <100.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/repaired\_rid.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Frepaired_rid.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3JlcGFpcmVkX3JpZC5leA==) | `16.66% <0.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/twcc.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Ftwcc.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3R3Y2MuZXg=) | `0.00% <0.00%> (ø)` | | | [webrtc/lib/endpoint\_bin/extension/vad.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree&filepath=webrtc%2Flib%2Fendpoint_bin%2Fextension%2Fvad.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi9lbmRwb2ludF9iaW4vZXh0ZW5zaW9uL3ZhZC5leA==) | `0.00% <0.00%> (ø)` | | | ... and [7 more](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/393?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute