search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Don't list S3 object if no files added in recording #396

Closed Rados13 closed 2 months ago

Rados13 commented 3 months ago

Changes:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.65%. Comparing base (f97ca4e) to head (bfe4bb0). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #396 +/- ## ========================================== - Coverage 54.68% 54.65% -0.04% ========================================== Files 75 75 Lines 3339 3341 +2 ========================================== Hits 1826 1826 - Misses 1513 1515 +2 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/396?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [webrtc/lib/webrtc/rtp\_connection\_allocator.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/396?src=pr&el=tree&filepath=webrtc%2Flib%2Fwebrtc%2Frtp_connection_allocator.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi93ZWJydGMvcnRwX2Nvbm5lY3Rpb25fYWxsb2NhdG9yLmV4) | `79.76% <100.00%> (ø)` | | | [recording/lib/guard.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/396?src=pr&el=tree&filepath=recording%2Flib%2Fguard.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-cmVjb3JkaW5nL2xpYi9ndWFyZC5leA==) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/396?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/396?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [f97ca4e...bfe4bb0](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/396?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).