search

fishjam-dev / membrane_rtc_engine

Customizable Real-time Communication Engine/SFU library focused on WebRTC.
Apache License 2.0
140 stars 11 forks source link

Only generate turn credentials once #402

Closed mickel8 closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.34%. Comparing base (cd61526) to head (5dca621).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #402 +/- ## ========================================== - Coverage 54.43% 54.34% -0.10% ========================================== Files 75 75 Lines 3336 3340 +4 ========================================== - Hits 1816 1815 -1 - Misses 1520 1525 +5 ``` | [Files](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/402?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) | Coverage Δ | | |---|---|---| | [webrtc/lib/webrtc\_endpoint.ex](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/402?src=pr&el=tree&filepath=webrtc%2Flib%2Fwebrtc_endpoint.ex&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev#diff-d2VicnRjL2xpYi93ZWJydGNfZW5kcG9pbnQuZXg=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/402/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/402?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/402?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Last update [cd61526...5dca621](https://app.codecov.io/gh/fishjam-dev/membrane_rtc_engine/pull/402?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fishjam-dev).
mickel8 commented 2 months ago

Closing as generating new credentials every time we get a request is correct. Password is calculated using username and secret