fishjam-dev / membrane_webrtc_plugin

Membrane plugin for sending and receiving media with WebRTC
Apache License 2.0
24 stars 3 forks source link

membrane_core branch develop does not exist #23

Closed peacememories closed 3 years ago

peacememories commented 3 years ago

Hi, and thanks for developing this very interesting framework. I have been trying to test membrane_webrtc_plugin, but for now I am stuck at including it as a dependency. The first problem I have is that the library depends on membrane_core on the branch develop, which does not seem to exist.

Overriding the dependency in my project leads to further errors, I gave up when membrane_funnel_plugin reported that Pad.ref was not allowed in pattern matches, which does work when just checking out that repository 😅

I'm pretty new to Elixir, so I don't know the best way forward here

peacememories commented 3 years ago

Okay, it seems like the reason this "works" when checking out the repository is that the correct commit is still mentioned in the mix.lock. If i copy that line to my lock file I get the same errors I was getting when overriding the dependency completely. So the immediate solution would be to change the branch in the mix.exs file to master, if that version is code-compatible.

mickel8 commented 3 years ago

Yes, mix.lock saves commit number that was used while including dependency. I think we will update it soon but as you wrote you can use membrane_core from master branch :wink:

peacememories commented 3 years ago

For now i basically copied the lockfile entries to my project and did some fixing until it compiled^^ As you said, it's enough for now, but I'm looking forward to the update :) Now on to actually getting the hang of membrane 😅