graszka22
commented
1 year ago @skyman503 If you have a while you can take a look at this PR, it shouldn't change much. Things that are not working yet:
- app on fabric crashes on ios (must be related to rn 71 -> 72 update or related updates) - probably expo and / or react-native-screens issue
- ~tests are broken, because we have missing dev libraries (react, react-native and react-dom) in package.json, however when I install them the app crashes because we have double react package 😅~ fixed
Focus on the code in modules, those thousands lines of changes are mostly yarn.locks, generated boilerplate etc.
skyman503
With this our sdk supports fabric architecture. How to test:
For Android: in the
gradle.propertiesfile there is a variablenewArchEnabled- set it to true to enable fabric architecture for example app (and therefore our sdk) HOWEVER there is a problem on some newer phones that on the second screen you can't click anything and it's probably a bug in react-navigation lib, it's being fixed by the open-source teamFor iOS: in the
example/ios/Podfile.properties.jsonthere is a variablenewArchEnabled, set it to true to enable fabric architecture for example app (and therefore our sdk) HOWEVER there is a bug in expo-font library and similar and all fonts and icons are broaken on fabric, expo team is working on thisAlso remember when switching between architectures to always clean cache etc. you may also need to delete
Podsorbuildfolders or even just clone the repo again :pWhen reviewing focus on the new modules (whether the code style is ok) and whether I've missed something (this repo is recreated from scratch 😅). Also react-native and other libraries are updated <3
Thoughts: