fishjam-dev / react-native-membrane-webrtc

Apache License 2.0
78 stars 8 forks source link

expo sdk 50 prebuild is not working #159

Closed chanphiromsok closed 6 months ago

chanphiromsok commented 7 months ago

can not find module @expo/config-plugins

image
chanphiromsok commented 7 months ago

it was resolved by using the exact expo version defined in @jellyfish-dev/react-native-membrane-webrtc it is work now

Please make it support for older version

karkakol commented 7 months ago

Hello, Thank you for your contribution. Could you provide a minimum example to reproduce this issue, for example in a GitHub repository? It would be the easiest way for us to see where the potential issue could be and, if necessary, to fix it as soon as possible.

chanphiromsok commented 6 months ago

clothify.zip

dont for get to run chmod +x scripts/env.sh give it permission to bash scripts then run yarn prebuild:dev --no-install --clean && yarn android:dev you will see error

karkakol commented 6 months ago

In provided example you don't use directly this repo jellyfish-dev/react-native-membrane-webrtcbut jellyfish-dev/react-native-client-sdk, today i released version 0.1.6 which uses expo 50 and react native 0.73, when i changed "@jellyfish-dev/react-native-client-sdk": "^0.1.5" to "@jellyfish-dev/react-native-client-sdk": "0.1.6" command above worked.

chanphiromsok commented 6 months ago

ahhh sorry you are right I used to installed @jellyfish-dev/react-native-client-sdk that autocompletion and blind me did not pay attention to it