fishpepper / OpenSky

opensource implementation of the frsky protocol for multiple targets (D4R-ii, VD5M)
http://fishpepper.de/projects/opensky/
GNU General Public License v3.0
155 stars 69 forks source link

Tidy of makefile for D4RII and movement of sources. #12

Closed blckmn closed 7 years ago

blckmn commented 7 years ago

Created this as a proposal to make it easier to add more targets and clean up a few things.

I plan on adding target for XSR and X4R-SB - so that the smart port connection can be used with simple D8 telemetry (same as on the D4R) instead of the more complicated sport polling protocol.

This will allow sharing of the comm port on Flight Controllers with SBUS (using RX pin) and Telemetry (using TX pin).

blckmn commented 7 years ago

Note that some of the targets will fail, and any assistance on getting those other targets up and running with the src and obj directories for this PR would be great :)

blckmn commented 7 years ago

@fishpepper there is a missing file hal_dma.h (and c) for the rasp build.

fishpepper commented 7 years ago

Thanks! that looks very good! i will integrate it once you finished your work.

dma.*: i see you use a wildcard in your makefile. dma.c was never built in my makefile. dma.c/dma.h should be removed from src then. It is empty anyway ;)

blckmn commented 7 years ago

I'll do some updates on the bootloader too, and re-add that in another PR.

blckmn commented 7 years ago

@fishpepper this is pretty much ready - though will need to complete the boot loader changes too for those to work fully. Can you please test and give me any feed back?

fishpepper commented 7 years ago

Looking good so far. Thanks! I am not at home right now, i will give you feedback the next days.

blckmn commented 7 years ago

Sorry - didn't realise there was a merge conflict now :) fixed.

fishpepper commented 7 years ago

looks good. I created a branch for this: https://github.com/fishpepper/OpenSky/tree/makefile_cleanup I re-added the bootloader code. I will now create a branch where i will add a stylechecker, this will take some time to get all the stylechecker complaints satisfied ;)

fishpepper commented 7 years ago

I finished the stylecheck stuff. See https://github.com/fishpepper/OpenSky/tree/stylecheck This includes all your changes + bootloader + stylecheck cleanup (with some makefile tweaks)

blckmn commented 7 years ago

Cool. @fishpepper is there anything further you want me to do?