fiskaly / fiskaly-sdk-swift

fiskaly Cloud-TSE SDK for Swift/iOS
MIT License
5 stars 5 forks source link

Force unwrapping could crash integrator #9

Closed marcelvoss closed 4 years ago

marcelvoss commented 4 years ago

Hi there,

as my team @sumup is currently looking at integrating this SDK, I went through the code base and noticed that there is extensive force unwrapping going on in places that make me scratch my head and scare me from integrating (for example here or here). In case one of these values is indeed nil, this will crash the integrator's app, during my investigation of the integration, it actually happened multiple times. Therefore, in its current state, the SDK is not safe to use for us.

We would appreciate it when the risk of integrating and using the SDK could become lower. Otherwise, the risk of having this crash our app is too high.

Thanks!