Bad handshake for servers using wss.

fiskaly / grafana.surrealdb

Grafana Datasource Plugin for SurrealDB

https://grafana.com/grafana/plugins/fiskaly-surrealdb-datasource/

Other

2 stars 1 forks source link

Bad handshake for servers using wss. #17

Open wms2537 opened 6 months ago

wms2537 commented 6 months ago

I wonder why is the protocol ws being hardcoded. For servers which require wss, it results in a websocket: bad handshake error.

https://github.com/fiskaly/grafana.surrealdb/blob/f1681f35603219b882e10dd76c70aed9ef81d26b/pkg/plugin/datasource.go#L97C2-L97C57

ppaulweber commented 6 months ago

@wms2537 thanks for pointing this our, I'll propose a backwards compatible change by allowing in an upcoming change and rollout that you can specify the location property in the following three flavors:

<location> which get's pre-fixed and post-fixed to ws://<location>/rpc
ws://<location> which get's post-fixed to ws://<location>/rpc
wss://<location> which get's post-fixed to wss://<location>/rpc