--min-bitrate seems not to work

[poeti8]

When I write --format flac --min-bitrate 2000 --max-bitrate 5000 I still get files downloaded with bitrates around 900.

[fiso64]

The file bitrate may be unavailable depending on the client used by the peer (I think the default soulseek client does not share the file bitrate, while nicotine+ does). slsk-batchdl skips the bitrate check if the bitrate is unavailable, this is probably why you are getting lower bitrate files.

I'll add an option to make it strict, but remember that setting a min-bitrate with that option will make it automatically ignore all downloads from peers who are using the default soulseek client.

[fiso64]

Try the new version https://github.com/fiso64/slsk-batchdl/releases/tag/v2.0.1 with --strict

[poeti8]

Thanks. Would there be a way to maybe filter based on the attributes?

[fiso64]

There is already --max-samplerate. Do you want to filter based on min sample rate or bit depth?

[poeti8]

There is already --max-samplerate. Do you want to filter based on min sample rate or bit depth?

Yes, exactly.

[fiso64]

I have added it in the latest version https://github.com/fiso64/slsk-batchdl/releases/tag/v2.1

[poeti8]

Sweet, it works like a charm.

Just one thing: Maybe it would make sense that --strict be the default behavior. Because why would I use --min-bitdepth if I don't want to strictly filter by the minimum bit depth.

[fiso64]

Because I suspect that most people aren't aware that this will also make it ignore files where the actual bitrate may be within the set bounds, but is not known because the peer is using a particular client. That would be unexpected behavior. But this is also unexpected behavior so I'll consider it.

[fiso64]

I have updated the readme to make it clear