search

fission-codes / auth-lobby

The authentication service that Fission services run.
https://auth.fission.codes
GNU Affero General Public License v3.0
12 stars 1 forks source link

Device linking with Brave fails: "Invalid asm.js: Unexpected token" #103

Closed justindotpub closed 1 year ago

justindotpub commented 2 years ago

Summary

Problem

Auth workflow for dashboard.fission.codes fails in Brave (with shields down)

Detail

Describe the bug Unable to complete login to dashboard.fission.codes

To Reproduce Steps to reproduce the behavior:

  1. Go to 'dashboard.fission.codes'
  2. Click on 'Sign in with Fission'
  3. Click on 'Sign in'
  4. Enter username and click on 'Link account'. Opening channel message appears in console. No error yet.
  5. In a different browser visit auth.fission.codes
  6. Confirm numbers match and click on 'Approve'
  7. Back in Brave, click on 'Yes' to allow access
  8. After a slight wait I see Invalid asm.js: Unexpected token in dev tools console. No progress beyond this.

As a side note, the first time I tried this I received an error about the service worker for ipfs.runfission.codes being blocked and assume it has to do with Brave defaults around service workers hitting a different domain. This happened to me another time as well. I have no idea why I can't reproduce that one repeatedly though. If I'm able to later I'll submit a new issue.

Desktop (please complete the following information):

matheus23 commented 2 years ago

Yeah this flow is confusing, but from looking at the steps you posted, it seems like starting from step 3, you were actually on auth.fission.codes, not on dashboard.fission.codes anymore, and what fails is device linking. It seems like there's something going wrong with the websocket connection.

I'll move the issue and rename it :v: