fission-codes / auth-lobby

The authentication service that Fission services run.
https://auth.fission.codes
GNU Affero General Public License v3.0
12 stars 1 forks source link

Fix issues with WebRTC #5

Closed icidasset closed 4 years ago

icidasset commented 4 years ago

For some reason it doesn't work at all on Safari. It gives an error that WebRTC is not supported, even though it is.

I looked at various apps that use https://github.com/libp2p/js-libp2p-webrtc-star as well, and it doesn't look like there is any special setup neccessary for Safari.

Examples:

No clue what's going on 🤷


That said, it looks like a better implementation is underway. About the *-star libraries:

These were never designed to be long term solutions, in fact, they were designed to be quick tools for demos. They have design flaws and worse, they end up re-implementing a lot of what libp2p already does (connection authentication, peer discovery, circuit-relay and rendezvous)

Source: https://github.com/libp2p/js-libp2p/issues/385

icidasset commented 4 years ago

More notes:

icidasset commented 4 years ago

UPDATE: Works for the most part with the circuit relay setup. Still some issues with Safari. Does not work at all on iOS Firefox and iOS Chrome, see https://github.com/ipfs/js-ipfs-utils/issues/50 for more info.

icidasset commented 4 years ago

Looks like it's fixed 🥳