fission-codes / auth-lobby

The authentication service that Fission services run.
https://auth.fission.codes
GNU Affero General Public License v3.0
12 stars 1 forks source link

New secret exchange flow using sessionStorage + iframe + postMessage #72

Closed matheus23 closed 3 years ago

matheus23 commented 3 years ago

Depends on https://github.com/fission-suite/webnative/pull/220

The iframe itself is super light and doesn't have huge dependencies (no IPFS).

I've also removed the "Warming up" UI, but only when the auth lobby uses the new exchange flow.

This PR can be tested on production at:

icidasset commented 3 years ago

By the way, not entirely sure about removing the warming up thing. We still need to show more specific loading messages when it needs to: load filesystem + create directories & files for permissions. But we can do that later 👌

matheus23 commented 3 years ago

By the way, not entirely sure about removing the warming up thing. We still need to show more specific loading messages when it needs to: load filesystem + create directories & files for permissions. But we can do that later :ok_hand:

Oh right, we can't get away with no filesystem changes, as the files/directories need to be initialized such that we have some read keys for them.

My thought process for removing the warmup thing was "it's faster now, so we can switch back to a simpler loading screen -> higher perceived performance for users".

But yeah maybe that's a discussion for another time. I'm thinking of removing that change for now :thinking: