search

fission-codes / dashboard

The account dashboard for the Fission platform
https://dashboard.fission.codes
GNU Affero General Public License v3.0
8 stars 0 forks source link

Remove CORS issue workarounds #7

Closed matheus23 closed 3 years ago

matheus23 commented 3 years ago

At the moment webnative.apps.deleteByDomain fails server-side, for some reason that causes CORS headers not being sent.

To work around the CORS issues, there's a try-catch-all in dashboard.

We should fix that issue remove this temporary code. https://github.com/fission-suite/dashboard/blob/8ef6e7031b8f6f20f2927e7e6c16349d9ba24ec9/src/Javascript/index.js#L60-L62

matheus23 commented 3 years ago

We can remove these CORS workarounds once https://github.com/fission-suite/fission/pull/488 is merged deployed.

matheus23 commented 3 years ago

In the meanwhile, I've fixed this in #9

Should still leave this open until we actually deployed the changes to production!

matheus23 commented 3 years ago

Fixed by #23