fission-codes / fission-cli

Rewrite it in Rust 🦀
Apache License 2.0
1 stars 1 forks source link

base64 Dependency duplication #14

Open pinkforest opened 1 year ago

pinkforest commented 1 year ago

This can be resolved at upstream did-key to bump libsecp256k1 to ^0.7.1 which has bumped base64 to ^0.13

Current did-key at ^0.2.0 this only bumps libsecp256k1 to ^0.5.0 which is the problem meanwhile it itself uses base64 at ^0.13

warning[B004]: found 2 duplicate entries for crate 'base64'
   ┌─ /home/foobar/pp/fission-cli/Cargo.lock:9:1
   │  
 9 │ ╭ base64 0.12.3 registry+https://github.com/rust-lang/crates.io-index
10 │ │ base64 0.13.0 registry+https://github.com/rust-lang/crates.io-index
   │ ╰───────────────────────────────────────────────────────────────────^ lock entries
   │  
   = base64 v0.12.3
     └── libsecp256k1 v0.5.0
         └── did-key v0.1.1
             └── fission v0.1.0
   = base64 v0.13.0
     ├── did-key v0.1.1
     │   └── fission v0.1.0
     └── fission v0.1.0 (*)
pinkforest commented 1 year ago

I raised with upstream at: https://github.com/decentralized-identity/did-key.rs/issues/36

Also PR for upstream to merge: https://github.com/decentralized-identity/did-key.rs/pull/37

pinkforest commented 1 year ago

Upstream has merged bump, waiting for a release.