fission-codes / fission-server

Apache License 2.0
9 stars 0 forks source link

Misc. workspace improvements #127

Closed QuinnWilton closed 1 year ago

QuinnWilton commented 1 year ago

There's a couple of things here, to hopefully fix all of the cargo warnings + get CI running again.

codecov[bot] commented 1 year ago

Codecov Report

Merging #127 (9887938) into main (c788aec) will decrease coverage by 1.46%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fission-codes/fission-server/pull/127/graphs/tree.svg?width=650&height=150&src=pr&token=GO3TTZLDO0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes)](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) ```diff @@ Coverage Diff @@ ## main #127 +/- ## ========================================== - Coverage 11.76% 10.31% -1.46% ========================================== Files 39 42 +3 Lines 1164 1328 +164 Branches 718 828 +110 ========================================== Hits 137 137 - Misses 930 1094 +164 Partials 97 97 ``` | [Impacted Files](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) | Coverage Δ | | |---|---|---| | [fission-server/src/db/connection.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL2RiL2Nvbm5lY3Rpb24ucnM=) | `0.00% <0.00%> (ø)` | | | [fission-server/src/db/mod.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL2RiL21vZC5ycw==) | `0.00% <0.00%> (ø)` | | | [fission-server/src/db/schema.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL2RiL3NjaGVtYS5ycw==) | `0.00% <0.00%> (ø)` | | | [fission-server/src/main.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL21haW4ucnM=) | `0.00% <0.00%> (ø)` | | | [fission-server/src/models/account.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL21vZGVscy9hY2NvdW50LnJz) | `0.00% <0.00%> (ø)` | | | [fission-server/src/models/email\_verification.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL21vZGVscy9lbWFpbF92ZXJpZmljYXRpb24ucnM=) | `0.00% <0.00%> (ø)` | | | [fission-server/src/router.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlci5ycw==) | `0.00% <0.00%> (ø)` | | | [fission-server/src/routes/account.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlcy9hY2NvdW50LnJz) | `0.00% <0.00%> (ø)` | | | [fission-server/src/routes/auth.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlcy9hdXRoLnJz) | `0.00% <0.00%> (ø)` | | | [fission-server/src/routes/health.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlcy9oZWFsdGgucnM=) | `0.00% <0.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/fission-codes/fission-server/pull/127?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/fission-codes/fission-server/pull/127/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes)
QuinnWilton commented 1 year ago

The nightly lints are going to fail because of a new check that's prone to some false positives, but otherwise this seems to fix CI