fission-codes / fission-server

Apache License 2.0
9 stars 0 forks source link

feat: implement websocket relay for account linking #144

Closed QuinnWilton closed 1 year ago

QuinnWilton commented 1 year ago

I haven't yet found a good way to test axum handlers that upgrade to a websocket connection yet, and we're probably need to do e2e testing against a server that actually runs and binds to connections.

This has been manually tested using ts-odd and AWAKE by hacking it up to change the endpoints it hits for device linking.

codecov[bot] commented 1 year ago

Codecov Report

Merging #144 (c178b1d) into main (cb139e9) will decrease coverage by 0.29%. The diff coverage is 0.00%.

:exclamation: Current head c178b1d differs from pull request most recent head 4d12edc. Consider uploading reports for the commit 4d12edc to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fission-codes/fission-server/pull/144/graphs/tree.svg?width=650&height=150&src=pr&token=GO3TTZLDO0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes)](https://app.codecov.io/gh/fission-codes/fission-server/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) ```diff @@ Coverage Diff @@ ## main #144 +/- ## ========================================== - Coverage 20.49% 20.20% -0.29% ========================================== Files 52 53 +1 Lines 1957 1990 +33 Branches 1207 1232 +25 ========================================== + Hits 401 402 +1 - Misses 1036 1066 +30 - Partials 520 522 +2 ``` | [Files Changed](https://app.codecov.io/gh/fission-codes/fission-server/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) | Coverage Δ | | |---|---|---| | [fission-server/src/app\_state.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL2FwcF9zdGF0ZS5ycw==) | `36.36% <0.00%> (+1.36%)` | :arrow_up: | | [fission-server/src/router.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlci5ycw==) | `19.35% <0.00%> (-0.65%)` | :arrow_down: | | [fission-server/src/routes/ws.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlcy93cy5ycw==) | `0.00% <0.00%> (ø)` | |