Closed icidasset closed 1 year ago
Merging #145 (14cab24) into main (c46e490) will decrease coverage by
0.23%
. Report is 3 commits behind head on main. The diff coverage is12.50%
.
Oh! I did just notice that the tests are failing now though, because the AppState
isn't being initialized with any peers during tests. Instead of making the peers required in the builder, I would recommend using unwrap_or_default
to default to an empty list of peers if none are provided.
Alternatively, more ergonomic would potentially be to not use an Option<Vec<_>>
there, and instead default to an empty Vec
, and just have a with_ipfs_peer
method for pushing one to the end of the list. That would make it easier to incrementally build up the peers for tests with semi-shared logic.
Alternatively, more ergonomic
Sounds good, I'll implement this and make sure the tests pass 👍
Changes:
/ipfs/peers
endpoint with a list of IPFS node addresses.