search

fission-codes / fission-server

Apache License 2.0
9 stars 0 forks source link

chore: Add `create_volume` to swagger docs #161

Closed matheus23 closed 1 year ago

matheus23 commented 1 year ago
matheus23 commented 1 year ago

Hm. We need a way to run kubo during tests.

blaine commented 1 year ago
  • Replaced ucan path dependencies with actual UCAN versions (@blaine this would still cause a runtime error, right? What's the github URL that I could depend on?)

Yeah, it's because the ucan:* "unscoped" bug in rs-ucan will result in proof chain validation failure. The "fix" I put in the vendored version was here: https://github.com/blaine/rs-ucan/tree/temporary-unscoped-fix (just a one line change), and I'm actually not sure the benefit of having a separate type for unscoped ucan: URIs so this may be the best overall fix (plus deleting related code)?

Anyhow, it's just on validating volume changes that things will fail until that issue gets resolved, or we can use a different resource (e.g. https://{domain}/api/account/{username}/*) instead of ucan:*

matheus23 commented 1 year ago

Ah - sorry for the huge diff in flake.nix. I actually have a nix formatter installed.

walkah commented 1 year ago

Hm. We need a way to run kubo during tests.

Might make more sense to just mock for CI?

Either way, can we get this merged so it's easier to build & run and work on a kubo testing strategy in a different PR?

matheus23 commented 1 year ago

Yeah, let's merge.