search

fission-codes / fission-server

Apache License 2.0
9 stars 0 forks source link

fix: Authenticate the `GET /api/v0/account` endpoint #211

Closed matheus23 closed 9 months ago

matheus23 commented 9 months ago

This was specified to work like that in design/api.md, and the CLI actually already adds authentication to the request. We... just never expected it. That's wrong, so this fixes it.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4945317) 21.07% compared to head (0c811c0) 21.04%. Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/fission-codes/fission-server/pull/211/graphs/tree.svg?width=650&height=150&src=pr&token=GO3TTZLDO0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes)](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================== - Coverage 21.07% 21.04% -0.04% ========================================== Files 72 72 Lines 3108 3108 Branches 1897 1898 +1 ========================================== - Hits 655 654 -1 Misses 1626 1626 - Partials 827 828 +1 ``` | [Files](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes) | Coverage Δ | | |---|---|---| | [fission-server/src/routes/revocations.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlcy9yZXZvY2F0aW9ucy5ycw==) | `45.45% <ø> (ø)` | | | [fission-core/src/capabilities/fission.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1jb3JlL3NyYy9jYXBhYmlsaXRpZXMvZmlzc2lvbi5ycw==) | `60.00% <66.66%> (ø)` | | | [fission-core/src/ed\_did\_key.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1jb3JlL3NyYy9lZF9kaWRfa2V5LnJz) | `53.84% <0.00%> (+2.12%)` | :arrow_up: | | [fission-server/src/router.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlci5ycw==) | `16.21% <0.00%> (ø)` | | | [fission-cli/src/cli.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1jbGkvc3JjL2NsaS5ycw==) | `0.00% <0.00%> (ø)` | | | [fission-server/src/routes/account.rs](https://app.codecov.io/gh/fission-codes/fission-server/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes#diff-Zmlzc2lvbi1zZXJ2ZXIvc3JjL3JvdXRlcy9hY2NvdW50LnJz) | `19.27% <25.00%> (-0.31%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/fission-codes/fission-server/pull/211/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fission-codes)