search

fission-codes / fission-vscode

A vscode extension for fast app publishing powered by IPFS ⚡️
https://marketplace.visualstudio.com/items?itemName=fissioncodes.fission
13 stars 1 forks source link

Updated dependencies + housekeeping. #4

Closed jeffgca closed 3 years ago

jeffgca commented 3 years ago

I wanted to review the vscode plugin as-is but noticed a difference in suggested macOS installation instructions between the online guide and the README for the vscode plugin. While patching this I noticed a few a other few small things that could also be updated:

  1. a dependabot alert for minimist
  2. npm run lint spewed warnings due to a spaces / tabs mismatch
  3. a few random missing semicolons.
jeffgca commented 3 years ago

...please let me know if y'all would rather this PR be split up etc.

expede commented 3 years ago

Thanks @therealjeffg 🙌

I haven't actually ever looked at this code before. Noted a few things as I'm working through it; may open a PR of my own shortly 😛