search

fission-codes / fission

Fission CLI & server
https://runfission.com/docs
119 stars 14 forks source link

Allow underscores in usernames & subdomains #467

Closed expede closed 3 years ago

expede commented 3 years ago

NB: Feature requests will only be considered if they solve a pain

Summary

Problem

Today, users are restricted to non-underscored usernames and app names (subdomains).

We need to blocklist _did and _dnslink if not already done.

Impact

People can't pick valid usernames. It's annoying 😛

Solution

Allow underscores in the validator

dholms commented 3 years ago

Closed here: https://github.com/fission-suite/fission/pull/468 And in the sdk: https://github.com/fission-suite/webnative/pull/180