search

fission-codes / fission

Fission CLI & server
https://runfission.com/docs
119 stars 14 forks source link

Let user know when their email is invalid #504

Closed erlandsona closed 3 years ago

erlandsona commented 3 years ago

closes #384

expede commented 3 years ago

Hmm don't worry about Cachix failing. We can figure that out separately 🤔 Possibly a key/permission thing with the fork, but need to look closer.

erlandsona commented 3 years ago

Yeh sounds good... and no worries. It was actually a good confidence booster as a first issue to just find my way around the code base and knock something out. Granted, if you want what was in your head feel free to elaborate and I'll do my best to accommodate. As in the other PR, I didn't actually know how to test this but given the requirements it seemed straightforward enough :man_shrugging:

expede commented 3 years ago

Granted, if you want what was in your head feel free to elaborate and I'll do my best to accommodate.

This PR is great as-is. Being pragmatic is a virtue 👍