search

fission-codes / fission

Fission CLI & server
https://runfission.com/docs
119 stars 14 forks source link

Upgrade DID multiformat #587

Closed matheus23 closed 2 years ago

matheus23 commented 2 years ago

Split out from #586

This upgrades the DID multiformat to the new version. We can't deploy this yet, because this PR will have the CLI generate new-style DIDs and browsers need to be upgraded to understand that format first.

What we could merge is support for reading the new DID RSA format, but generating the old RSA format.

However for now this is just some reviewable commits extracted from #586, so we can split reviewing into rounds.

expede commented 2 years ago

We can't deploy this yet, because this PR will have the CLI generate new-style DIDs and browsers need to be upgraded to understand that format first.

Could we break out the format into its own type as another Oldstyle, use it at the call sites, and merge the new style code, just to get it in main? The advantages are that we don't need to keep rebasing this branch, and flipping over to the new style DIDs would be like 12 LOC (just the call sites).

matheus23 commented 2 years ago

Facepalm

I got hardcore deja-vu when reading through these changes. For a good reason: There's already this: https://github.com/fission-suite/fission/pull/573

For some reason I thought these changes didn't make it into main yet, but this confusion all stems from git branch confusion. :woozy_face:

Please ignore this @expede!