fission-codes / fission

Fission CLI & server
https://runfission.com/docs
119 stars 14 forks source link

Make welcome email optional #598

Closed bgins closed 2 years ago

bgins commented 2 years ago

Summary

Problem

When a user registers an account, they are sent a welcome email. In app-owned auth apps, this email will be unexpected and out of context.

Impact

The welcome email exposes to the user that their account is a Fission account. Developers need to inform users that they will receive an email from Fission and why.

Solution

Make the welcome email optional. We could add a querysting param to the PUT /v2/api/user endpoint that indicates whether the email should be sent or not.

From the webnative side, we dependency inject a registration function and app-owned auth apps could opt-out of the welcome email.

Detail

Additional context

Longer term, we may consider providing the welcome email to developers who have registered a custom domain name and user namespace for their app(s).

bgins commented 2 years ago

Closed in favor of #616, which will make email at registration entirely optional. If a developer does not want the welcome email to be sent out, they can register users with a username only.