Closed bgins closed 2 years ago
Code looks super reasonable π I'm just going to build it and take it for a spin :)
Looks good π
[nix-shell:~/Documents/Work/Fission/fission]$ fission generate credentials
β
Generated an Ed25519 key pair and associated DID
ποΈ Private key: [XXXXXXXXXXXXXXXXX]
π Public key: U/yng963O2x+zVk+QlQAsMkgwyU2r1sMQWUALX6DEXU=
π DID: did:key:z6Mkk77LH6Qh1rPPqcdegByTKj9LKRHphKdotyr3skm6AYct
Will the extra π Public key
field be confusing for this use case? π€ I guess it's good to have it to be generic?
Oh @bgins don't forget to bump the version before merging!
Will the extra
π Public key
field be confusing for this use case? π€ I guess it's good to have it to be generic?
@expede keeping it general was my thought here. We won't need it for the app append feature, but it could be useful in other use cases. We can write up some instructions for the append feature/commands explaining that they'll only need the private key and DID.
Summary
This PR adds a
fission generate credentials
command to create Ed25519 key pairs and their associated DIDs.This PR fixes/implements the following bugs/features
fission generate credentials
commandThe credentials subcommand has no options and only generates Ed25519 key pairs
The output prints a private key, public key, and DID
This PR also adds a top-level
generate
command with no fallbacks. It must be used with thecredentials
subcommand. The description for thegenerate
command infission --help
is "Generate key pairs and DIDs".Test plan (required)
Compile, then run the
fission credentials generate
command to generate a test key pair and DID.Check the help text for
fission
,fission generate
andfission generate credentials
.Closing issues
Closes #613
Tasks
After Merge