fission-codes / go-car-mirror

Generic Go implementation of the CAR Mirror protocol
Apache License 2.0
4 stars 0 forks source link

Look into error, ErrCantMarshalBloomWithoutHashId #105

Closed justindotpub closed 1 year ago

justindotpub commented 1 year ago

I ran into this while making some changes to the event loop. Saving here in case there's some needed defensive programming this exposes.

2023-02-17T14:57:05.935-0600    DEBUG   go-car-mirror   filter/filter.go:537    exit    {"object": "BloomFilter", "method": "MarshalJSON", "error": "ErrCantMarshalBloomWithoutHashId", "bytes": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=", "hashFunction": 0, "hashCount": 12, "bitCount": 16384}
2023-02-17T14:57:05.935-0600    DEBUG   go-car-mirror   core_test/carmirror_test.go:126 sending {"object": "StatusChannel", "method": "SendStatus", "state": "SINK_FLUSHING|SINK_SENDING", "haveError": "json: error calling MarshalJSON for type *filter.SynchronizedFilter[github.com/fission-codes/go-car-mirror/fixtures.BlockId]: json: error calling MarshalJSON for type *filter.BloomFilter[github.com/fission-codes/go-car-mirror/fixtures.BlockId]: bloom must be created with a hash Id in order to marshal it", "want": [{"id":"WIs8TOVsp+pAeyOupVjhJw1fWOWKSI4zgK/QQgHlgkg="},{"id":"0C6R3Ab6+wc+A+JNkSg6A3K4TeIdvVP9mOC8f45xtgw="},{"id":"7RHN0bG6gRyasWq8iMVd7vAGx+mQyujNcOQjGYJd57E="},{"id":"/3ob5ollgFamXbjZwi5JwnUUD6sYqyg4EinQxcz/FQc="},{"id":"ScIpyXuF92UFHzjl+/CCZU21jk8kAp0ypGBKL1G75Ww="},{"id":"dDSlY84DLMUMe43WMVt1XoVg5u2zN95/epTv9rLhbJg="},{"id":"VmCPb+bB7iGHlTtYpoKjz4LPc+vRyFr2AGYtmBnp4nA="},{"id":"o+BEpukMFjSzeIOkiQlKFHVpqINt1g/dghVwvRDfa6k="},{"id":"26Jf43PBkZ2bvozK77+IIDy7d1gsjiXkJdJQ3vFuxf4="},{"id":"DVce9TBKLyJPdFdIy2E5C70s/Hak/Rlznis5SxzYNaQ="},{"id":"kC5L16tssJOsS7+DGRMyI0vBniTgmdtKIs/Jw0/Fox0="},{"id":"hTQsyDWpPPVtIx0fCziSDUKIePxVe6NWUZZk9U1KVt4="},{"id":"U9fSZ68t9Vadh78Qvs1L008Q+TpFJFjMMVGcicQ/vXs="},{"id":"jPTHtF8KXKlvGrXGaX7XSIh+pUwZKn0H/KUL4AXWGfg="},{"id":"0FWHLctKIEGgONucBFzi6SOtaK5CXnK1UUIz/ZAQAns="},{"id":"+gqc9+Z86W2n/2mwtM2Bgj6QNUJwEyWBFevR22p0bEA="},{"id":"qNN76IIMPs2yHWxV3/qlPaBJNCpz/Dl12CtGzRoJ7TM="},{"id":"J7/8T9eHdQk8qbYh4iQM8XEUNNjelUI2z/aweQ8JFtk="},{"id":"1ImZ6U08Zm98poQznKxs7RZ/mGahlj41JoT8YbzjJQE="},{"id":"Set9uB0CFuXWOBoELNsgCvAFCe9ovXQot0fNEgvJ6Yk="},{"id":"gcn+Ybv0oFI432HOW3yqGGvVW7PQVjQDYkL+nMk4I7E="},{"id":"JNYkbsZhxyKMuNeG43ok7zOLioWwh+blSvBkYjjSnk0="},{"id":"TPCUhQ00L9iM95gbDNet0KGBf5gTvd1XpLrFHSadqRI="},{"id":"jZkKgHmKoQY0JJNCh+6XngrkhIDKDLH04sYG+f7NEOI="},{"id":"Li6lNR9hJ5qiM/qL0n2+yj2sBS/dPhiSoEncwYvcI/E="},{"id":"QH7R4jdQ3VWmJTwWWsjdCmEsokjAqvl869I2USADFEk="},{"id":"qAKpYKYEQCK+plv9S3CCihZwD2cQo9FTlx6mLRG4o7Q="},{"id":"kf834prCmJKBr12nDZJ+3Cq4bNAn7VAs1cMtNtEcMMo="},{"id":"ZAqMQlqqKPYL+/OZJOtrxl5KTMJQx6MBbiZLZH2lUgA="},{"id":"iVkE2qPPUiUB4cpuuIsYT7PLrGemg5qFFAXrOb/4UEA="},{"id":"OjqUtocr0SBYDJG9uE1Y77jIPnoU+SlDkBBN2Uv951s="},{"id":"xWJy/lfgBkJeB6GnF8SYEBchJgKZdmxJZq7TCw1UFO4="},{"id":"tM7/180wG829yg+BScPOF3VsxZgn8UHut6Va8e5hvPw="},{"id":"51p1j9yZ65y0UhOJbL9BkY/CtI9Fm4aEaVmh096JfPg="},{"id":"9GbPdvVDEuP/Jm4EIqldxPs8UB8vOsrhuyE567inVOM="},{"id":"YqK8yfQmPI6fK1WLwbexs3fBKwkIDBhvq1oLh61A/+s="},{"id":"8BauL1oa+Nx7e7nQSprNFJNo2miQ5xwNCfGcPrA+1Ys="},{"id":"Qg8B0nWv6P5sTvfESpdzyWm0hXk09wDDDqRR+DjWxP8="},{"id":"bN/SsXz0dVUhI1ILeWbMUE9MapDA+RV3h+kRenb4dM8="},{"id":"2zlSstSgyaicOIkjubiF89fLz599Mo1fnYC83v0KQOc="},{"id":"cAiGhiO1PHRijz1HOgU/oLVNx3EB43AoTsFZLbv55CU="},{"id":"xRYulPNWgN98ScNkpLK6S9nRrRxbqRUobOPaAWanCzw="},{"id":"19cFLSrxzuKy9qGFGFkt6sWPlfgUbRKyib6EqanJyEw="},{"id":"0cN6BVzCFjDtCYOW3+/fnzScIvOek5JZLCBSBGeTXdk="},{"id":"x+6x9Plt0P3KfR9Xa7KHMip4Dsgl5lM4CXD2OvgqPac="},{"id":"jtzqYZrIbAg0q9/CQBgVYx5ZbVcMCUJ50DhEfDZW394="},{"id":"IXAPqwofkl7DJlZM76GvEDdKu3lIc+GjaQ/yIf3mfvM="},{"id":"ubDa8IPoRk6ELErI2X2T/Rf2TJCi8xSixMaA0x2QKOs="}]}
justindotpub commented 1 year ago

This had to do with how tests were configured. Fixed.