search

fission-codes / go-car-mirror

Generic Go implementation of the CAR Mirror protocol
Apache License 2.0
4 stars 0 forks source link

Message shape #83

Open justindotpub opened 1 year ago

justindotpub commented 1 year ago

In the current code, the message shape doesn't match the spec. Make sure they are both in sync. Also note the conversations we had on the optional state field we currently have being allowed but not in the spec, and the spec making it clear that extra fields must be tolerated, in the spirit of Postel's law... "Be conservative in what you do, be liberal in what you accept from others."

ETA: 2024-02-15

justindotpub commented 1 year ago

I've removed the state field now, so that is no longer relevant. Still need to make sure we match spec and abide by Postel's law regardless.