fission-codes / go-car-mirror

Generic Go implementation of the CAR Mirror protocol
Apache License 2.0
4 stars 0 forks source link

Straggler cleanup #84

Open justindotpub opened 1 year ago

justindotpub commented 1 year ago

Ensure that code and spec are in sync as relates to straggler cleanup.

In particular, the spec says that once a sink receives blocks, it traverses the children until it finds missing blocks. Then it returns the PARENTs of those missing blocks as the subgraph roots, not the missing children themselves.

Then per the spec, if the "Provider begins returning only the requested roots but no other blocks, the Requestor MAY initiate a cleanup round".

Make sure we are doing this or adjust the spec if needed. Some discussion at https://talk.fission.codes/t/notes-on-car-mirror-push/3355/3.

ETA: 2023-10-31