search

fission-codes / heroku-ipfs-ghost

The Ghost blog system upgraded with Heroku deploys & IPFS support.
MIT License
15 stars 17 forks source link

Code Cleanup #15

Open tcyrus opened 4 years ago

MCTaylor17 commented 4 years ago

Hi @tcyrus and thanks for contributing to the project.

I thought it might be helpful to provide some context before discussing the updates. This project is a fork of a fork of ghost-on-heroku repo. The original has had minor changes to the documentation as early as 12 months ago, although I don't see any substantial changes to the codebase since Nov 2017.

This means there are a number of opportunities for modernization as I'm sure you've noticed. It also means there are two main approaches to this type of work:

  1. update here and send PR upstream
  2. update there and merge updates downstream

Perhaps @bmann has an opinion on how best to manage this type of decision on an open source project?

bmann commented 4 years ago

Upstream is unmaintained. We’ll continue to maintain this as we use it ourselves to run our blog and use it as a demo of our Fission IPFS Heroku add on.

@MCTaylor17 thanks for the PR review! Will get rest of team to look as well.