Re-enable minor update (or update documentation)

fission-codes / heroku-ipfs-ghost

The Ghost blog system upgraded with Heroku deploys & IPFS support.

MIT License

15 stars 17 forks source link

Re-enable minor update (or update documentation) #9

Closed MCTaylor17 closed 4 years ago

MCTaylor17 commented 4 years ago

According to documentation:

Upgrading Ghost

On each deployment, the Heroku Node/npm build process will auto-upgrade Ghost to the newest 3.x version. To prevent this behavior, use npm 5+ (or yarn) to create a lockfile.

During upgrades, package lock was added and package files were changed from ^(minor) to ~(patch) based on a related conversation. These will need to be reverted to allow for the described functionality.

bmann commented 4 years ago

Yep will likely archive current version of the README and trim it down to be very specific.

Pro: package.lock means we know that the current version works when last tested.

Con: every time dependencies are updated, new package.lock needs to be manually checked in.

There are a number of ways to solve this. Will either encourage people to fork, turn this repo into a template, maybe use the “pull” app to stay up to date with this master, etc.

MCTaylor17 commented 4 years ago

I just added PR #10 to address the README issue #7. Beyond the citation in the OP, I also noticed another reference under the Ghost v3.x heading:

Removed package-lock.json so that newest packages are used automatically

MCTaylor17 commented 4 years ago

There are a number of ways to solve this. Will either encourage people to fork, turn this repo into a template, maybe use the “pull” app to stay up to date with this master, etc.

I just noticed you can deploy from branches as well 🤔

bmann commented 4 years ago

I've updated docs for now.