search

fission-codes / kubo-car-mirror

Implementation of the CAR Mirror protocol for Kubo
Apache License 2.0
10 stars 4 forks source link

Revisit definition of subgraph roots #34

Closed justindotpub closed 1 year ago

justindotpub commented 2 years ago

What is a better definition for subgraph roots?

  1. leaf nodes with unsynchronized children
  2. the unsynchronized children themselves

Trade offs to either decision.

Option 1 returns fewer CIDs but has more chance of sending duplicate CIDs, since we don't know which of the children are unsynchronized.

Option 2 returns more CIDs, but the CIDs are an accurate list of what wasn't synchronized.

Currently the spec has option 1. Do we need benchmarks to see what the size and perf diffs are?

justindotpub commented 1 year ago

Moving to a separate list of things to consider for spec change.