fission-codes / landing-page

Fission home page
https://fission.codes
Other
9 stars 2 forks source link

Add social metadata to pages and push error handling upstream #26

Closed matheus23 closed 4 years ago

matheus23 commented 4 years ago

Work on #22 and #25.

This PR makes it possible to configure site metadata in the frontmatter of yaml files, like this: https://github.com/fission-suite/landing-page/blob/530024f14612b3df769305022bfab7a1c018f7fb/content/index.yml#L3-L7

Some notes:

PWA metadata still has to be configured in elm directly. There's no other way to get access to the yaml in the right places with elm-pages' current design, unfortunately. https://github.com/fission-suite/landing-page/blob/530024f14612b3df769305022bfab7a1c018f7fb/src/Content/Metadata.elm#L141-L155

matheus23 commented 4 years ago

If anyone wants to test the current version, I've uploaded it to fission here: https://young-thick-turquoise-ghost.fission.app

We might want to create images specifically for preview cards with a little more padding. It looks like the previews are often cut. Maybe this can be fixed with correct aspect ratios?

bmann commented 4 years ago

Yeah custom images are usually the case.