Closed avivash closed 2 years ago
Sorry @avivash I didn't even notice this was flagged for me. Want to take this out of draft and give it a try?
Sorry @avivash I didn't even notice this was flagged for me. Want to take this out of draft and give it a try?
ahh, sorry I meant to bring this up earlier 😅 yeah, everything's working aside from that weird styling issue i mentioned, so I can merge this for now then sync up with Nolo after and ask why the css classes specified in discourse aren't being added to the iframe when it's rendered 👍🏼
Description
Adding discourse comments to blogs posts. For whatever reason, the classes defined here aren't being added to the iframe
, so i've done some very slight styling to the outside of the iframe for now just to clean up the spacing a bit. Once that class starts being applied, I'll be able to do more thorough styling to make it match the rest of the site and maybe add styles for light and dark modes. The fission logo inside the iframe is hard to see because the text is white and the background is white too, so that's another thing i'll be able to update once I figure out why this class isn't being applied correctly.
I'll keep this PR in draft mode while I dig a little deeper into why the class isn't being added. (I can probably hack the styles using some JS, but i'd like to avoid that if possible)
Link to issue
https://github.com/fission-suite/landing-page/issues/74
Type of change
Screenshots/Screencaps
Light mode with no comments:
Light mode with comments:
Dark mode with no comments:
Dark mode with comments: