fission / fission-workflows

Workflows for Fission: Fast, reliable and lightweight function composition for serverless functions
Apache License 2.0
371 stars 42 forks source link

Add default CMD and ENTRYPOINT to bundle image #233

Closed erwinvaneyk closed 5 years ago

erwinvaneyk commented 5 years ago

The fission-workflows-bundle image has two functions: 1) it serves as a container of all binaries of the same build. Other images use this image to grab a specific binary from it and modify it according to the use case. 2) for the plain fission workflows server, the fission-workflows-bundle is used directly.

The last use case is not as straightforward as it could be right now. To run a basic version of the workflow-engine you need to modify both the ENTRYPOINT and CMD on a docker run, which is cumbersome to do from the top of your head.

This PR solves this by adding a ENTRYPOINT and CMD to the Dockerfile. These are intended as sensible defaults to allow users to run an instance as simple as: docker run -p 5555:5555 -p 8080:8080 fission/fission-workflows-bundle. Advanced users and the Helm charts still override these settings.