fission / fission.io

Fission.io website
https://fission.io
5 stars 41 forks source link

Doc issue: Packaging source code #217

Open hklang10 opened 1 year ago

hklang10 commented 1 year ago

example env create contains --poolsize argument but not --version, so poolsize is ignored.

fission env create --name pythonsrc --image fission/python-env:latest \
                     --builder fission/python-builder:latest \
                     --mincpu 40 --maxcpu 80 \
                     --minmemory 64 --maxmemory 128 \
                     --poolsize 2

should read:

                     --poolsize 2 --version 3
hklang10 commented 1 year ago

same issue is also in https://fission.io/docs/usage/function/functions/

hklang10 commented 1 year ago

the CLI doc says the default is 1 however fission env create (in V1.17) does seem to set the version inconsistently (seems to be dependent on language, and if --builder is used.)

For consistency, the docs might be better to explicitly set --version when using --poolsize.

Will push some PRs to make this consistent.