search

fit-ctu-discord / honza-botner

Bot for FIT CTU Discord
https://discord.fit.cvut.cz/
MIT License
15 stars 10 forks source link

[Bug] Get rid of techical roles in role config #475

Closed stepech closed 3 months ago

stepech commented 1 year ago

By the logic from Vic website, technical roles are used to grant some higher privileges in some specific university systems. Business roles on the other hand represent the current status of the person. As we have found out recently, some of the technical roles are not revoked after their corresponding business role is. We should switch checks to business roles to get up-to-date and correct info and avoid some KOS-specific setups which we don't understand. image

stepech commented 1 year ago

VIC was faster and got rid of Technical roles before us. I am not sure if they have some backwards compatibility in place, but there is now possibility that verification no longer works in some cases.

JanBliznicenko commented 3 months ago

VIC was faster and got rid of Technical roles before us. I am not sure if they have some backwards compatibility in place, but there is now possibility that verification no longer works in some cases.

True, adding discord Teacher role no longer worked for me as the only teacher-like usermap role I have is B-18102-KOS-UCITEL

stepech commented 3 months ago

@JanBliznicenko do you also have B-18000-UCITEL or something like that?

JanBliznicenko commented 3 months ago

@JanBliznicenko do you also have B-18000-UCITEL or something like that?

No, B-18102-KOS-UCITEL is the only role with "UCITEL" or anything similar in it. I have many SUMA roles and 18000 roles, but only for student, doktorand, zamestnanec, pracovnik etc.

stepech commented 3 months ago

Solved