fithamlak / Recipe-App

Recipe App is app in which it allows a user can add different recipe and watch other public recipes.
MIT License
0 stars 0 forks source link

RoR project setup #9

Open fithamlak opened 1 year ago

fithamlak commented 1 year ago

https://github.com/fithamlak/Recipe-App/projects/1

julie-ify commented 1 year ago

Hi @fithamlak and @gealsanchez,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

The link to the Kanban board should be included in the issue you submitted.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

alexander16108 commented 1 year ago

Hi @fithamlak @gealsanchez ,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

1GORDON commented 1 year ago

Status: APPROVED 🟢

Hi @gealsanchez, and @fithamlak ✋

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! :tada: :clap: :clap: :100:

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread and tag me @1GORDON if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.