fititnt / uwazi-docker

Dockerized version of Uwazi (“openness" in Swahili). HURIDOCS designed Uwazi to make human rights information more open and accessible to the defenders who need it.
The Unlicense
11 stars 4 forks source link

Wrong clone command in README.md #15

Closed vasyugan closed 5 years ago

vasyugan commented 5 years ago

git clone git@github.com:fititnt/uwazi-docker.git does not work for me.

For me, the URL

https://github.com/fititnt/uwazi-docker.git

works

fititnt commented 5 years ago

Good catch!

Did you want to make the pull request or I do it?

vasyugan commented 5 years ago

I just tried to clone the code following the instructions in the readme, nothing else.

fititnt commented 5 years ago

Ah!

To submit changes (without having push permission to a repository) is need to push to a forked version. Is possible to do it even using just the web interface if the forked repository and the main repository are in sync. I think if you go on https://github.com/fititnt/uwazi-docker/blob/master/README.md and click edit, the github interface will automatically create a fork with the recent changes and suggest you to click on some green button to make the pull request.

We have some time for that, only if you have more trouble with this I will make this change. Also, if you do more changes (like the one you already discovered on elastic search memory issues; and maybe add comments on the docker-compose.yml files mentioning that the non open version of Elastic Search / JVM is easier to deal with memory) is easy for me and you make you with write access to this repository, but for this is interesting know just a bit more about git.

vasyugan commented 5 years ago

@fititnt Ah, ok, I actually misread you. Indeed, I can try. Curious how this works.