search

fitnr / convertdate

Utils for converting between date formats and calculating holidays
MIT License
47 stars 24 forks source link

Add support for non-Western Easter #23

Closed tla closed 5 years ago

tla commented 5 years ago

This pull request includes calculation of Easter for the Orthodox and other eastern churches, and also allows expression of the date of Easter in any of the supported calendars.

fitnr commented 5 years ago

This looks good. I don't think it's necessary to include an internal method for converting to other calendar systems. I would prefer if each method return results a specific calendar system. I think this will make for more readable code. I make some adjustments with that in mind and pull this in to the repo

fitnr commented 5 years ago

As I mentioned above, I decided to remove the function to change the function output into any system. I also added a few more tests and rebased this onto master branch. It's been merged here: 081ee4b.

Thanks so much for your contributions, this is a great addition to the library.