fitnr / convertdate

Utils for converting between date formats and calculating holidays
MIT License
47 stars 26 forks source link

Additional Hebrew Calendar Holidays #25

Open eyammer opened 4 years ago

eyammer commented 4 years ago

I would like to add some additional Hebrew calendar holidays but I don't know how to initiate that. I wrote the code, but I don't know the process for initiating the feature and making the pull request.

def shemini_azeret(year, eve=None):
    year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.TISHRI, 22)
    if eve:
        day = day - 1
    return year, month, day

def lag_baomer(year, eve=None):
    year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.IYYAR, 18)
    if eve:
        day = day - 1
    return year, month, day

def tu_beshvat(year, eve=None):
    year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.SHEVAT, 15)
    if eve:
        day = day - 1
    return year, month, day

def ninth_av(year, eve=None):
    year, month, day = hebrew.to_jd_gregorianyear(year, hebrew.AV, 9)
    if eve:
        day = day - 1
    return year, month, day

@property
    def tu_beshvat(self):
        return tu_beshvat(self.year, eve=False)

    @property
    def shemini_azeret(self):
        return shemini_azeret(self.year, eve=False)

    @property
    def lag_baomer(self):
        return lag_baomer(self.year, eve=False)

    @property
    def ninth_av(self):
        return ninth_av(self.year, eve=False)```
ohadeytan commented 4 years ago

It is great to see new contributions :)

You can look at my old pull request as an example. Notice that Tisha B'Av could be postponed, you should handle that.

eyammer commented 4 years ago

Will do. Also, good call about Tish B'Av